Miscellaneous updates and fixes by setrofim · Pull Request #45 · veraison/eat

setrofim · 2026-10-09T09:32:45Z

A number of additions and fixes to support work on github.com/veraison/ear.

add MustNewProfile()
implement TextMarshaler and TextUnmarshaler for IntOrString
handler empty input in Submod.UnmarshalJSON()
change NewNestedToken() to accept NestedTokenType rather than string as its type parameter
add int and uint conversions to IntOrStringFromAny()
add IntOrStringMapFromAny()
add NonceFromAny()
install a local golangci-lint and use that in the make target; update CI to do the same
update CI to align Go version with go.mod
add String() to Profile

Add MustNewProfile() a panicking version of NewProfile. This removes the need for useless error checks when creating a profile form a known good value. Signed-off-by: setrofim <setrofim@gmail.com>

Implement text marshaling for IntOrString. This allows IntOrString to be used as map keys when marshaling to/form JSON. Signed-off-by: setrofim <setrofim@gmail.com>

Check that input text (after truncation) is at least one character long before attempting to guess the format by examining the first character. Stops panics on empty input. Signed-off-by: setrofim <setrofim@gmail.com>

Change the type of the first parameter from string to NestedTokenType. This is more natural as, in most cases, the type will be know at the time of creation. This also removes the need to parse the type out of the provided string. Signed-off-by: setrofim <setrofim@gmail.com>

yogeshbdeshpande

have left some comments, but in general looks good to me!

yogeshbdeshpande

LGTM!

thomas-fossati · 2026-10-09T11:32:33Z

+	case int:
+		ret.val = t
+	case uint:
+		if t > math.MaxInt64 {


hmm, this will not work on a 32-bit platform

we need to wrap t (i.e., uint64(t))

do we care about 32 bit platforms? Outside of very small embedded systems I haven't seen one in over a decade.

(I've updated as you suggested, just seems a weird concern.)

do we care about 32 bit platforms? Outside of very small embedded systems I haven't seen one in over a decade.

(I've updated as you suggested, just seems a weird concern.)

IIRC, Huawei research (Sampo, Vijay) were using veraison components on M-class via EmGo/TinyGo.

Oh, really? I remember they experimented with it, but I didn't think those were successful.

thomas-fossati · 2026-10-09T11:35:57Z

+func (o IntOrString) MarshalText() ([]byte, error) {
+	return []byte(o.String()), nil
+}
+
+func (o *IntOrString) UnmarshalText(data []byte) error {
+	*o = IntOrStringFromString(string(data))
+	return nil
+}


these two do not roundrtip: string("1") becomes int(1). Worth documenting it (also, these are public methods and should have their doc strings).

They do. string("1") and int(1) both convert to IntOrString{1} (When given a string, IntOrString attempts strconv.Atoi() for precisely this reason: https://github.com/veraison/eat/blob/setrofim/misc/int_or_string.go#L70)

Regarding doc comments -- I thought that for interface implementations, the comments are on the interface, not the implementation? (e.g. we don't usually put doc comments on MarshalCBOR either).

They do. string("1") and int(1) both convert to IntOrString{1} (When given a string, IntOrString attempts strconv.Atoi() for precisely this reason: https://github.com/veraison/eat/blob/setrofim/misc/int_or_string.go#L70)

oh, right! Sorry for the noise.

Regarding doc comments -- I thought that for interface implementations, the comments are on the interface, not the implementation? (e.g. we don't usually put doc comments on MarshalCBOR either).

It's a method exported by the package, so strictly speaking we should document it. Why not making it private then?

It needs to be public for the same reason as MarshalCBOR(), etc.

Add the previously missing conversions for int and uint to IntOrStringFromAny. Additionally, update the error message for unknown inputs to not talk about "unexpected algorithm", which does not necessarily make sense, depending on the context in which the IntOString is used. Signed-off-by: setrofim <setrofim@gmail.com>

Add a function to create a map[IntOrString]any from any input. While not used in the library itself, it is useful for working with EATs externally as they often define int keys for CBOR and string keys for JSON (and CBOR could potentially have a mix of int and string keys). Signed-off-by: setrofim <setrofim@gmail.com>

Add a function to convert any input into a Nonce. This is useful when dealing with a generic unmarshaled claims (e.g. form a map[IntOrString]any). Signed-off-by: setrofim <setrofim@gmail.com>

Install a local version of golangci-lint into tools-bin/ and use that when running "make lint". This ensures that we have a known version of the linter that was built using the same Go version as the code base being linted. Additionally, upgrade the version used to v2.13.2, and fix up a couple of new issues highlighted by the upgraded linter. Finally, remove lint-extra target, as it is pretty much ignored anyway. Signed-off-by: setrofim <setrofim@gmail.com>

Run lint via "make lint" which installs a known version locally, and removes the need to install a pre-built version via GitHub actions. Signed-off-by: setrofim <setrofim@gmail.com>

Update the Go version used in flows to 1.26 to align with the version declared in go.mod. Signed-off-by: setrofim <setrofim@gmail.com>

Add String() to Profile. Profile already has Get(), but that can be awkward to use since you need to check the error. A lot of the time that is unnecessary since you're comparing the string to a specific value; besides the error can only occur when the profile is uninitialized. Signed-off-by: setrofim <setrofim@gmail.com>

thomas-fossati

thanks, 🚢 it!

setrofim added 4 commits October 9, 2026 09:38

feat: add MustNewProfile()

5dba805

Add MustNewProfile() a panicking version of NewProfile. This removes the need for useless error checks when creating a profile form a known good value. Signed-off-by: setrofim <setrofim@gmail.com>

feat(int_or_string): implement TextMarshaler and TextUnmarshaler

57204e1

Implement text marshaling for IntOrString. This allows IntOrString to be used as map keys when marshaling to/form JSON. Signed-off-by: setrofim <setrofim@gmail.com>

fix(submod): UnmarshalJSON with an empty input

4256e94

Check that input text (after truncation) is at least one character long before attempting to guess the format by examining the first character. Stops panics on empty input. Signed-off-by: setrofim <setrofim@gmail.com>

setrofim requested review from thomas-fossati and yogeshbdeshpande October 9, 2026 09:32

setrofim force-pushed the setrofim/misc branch from 40ae4de to 127d8fc Compare October 9, 2026 10:04

yogeshbdeshpande reviewed Oct 9, 2026

View reviewed changes

Comment thread nonce.go

yogeshbdeshpande reviewed Oct 9, 2026

View reviewed changes

Comment thread nonce.go

yogeshbdeshpande reviewed Oct 9, 2026

View reviewed changes

setrofim requested a review from yogeshbdeshpande October 9, 2026 11:15

yogeshbdeshpande approved these changes Oct 9, 2026

View reviewed changes

thomas-fossati reviewed Oct 9, 2026

View reviewed changes

setrofim force-pushed the setrofim/misc branch from 127d8fc to b9c3768 Compare October 9, 2026 12:06

setrofim added 6 commits October 9, 2026 13:12

feat(nonce): add NonceFromAny()

a573deb

Add a function to convert any input into a Nonce. This is useful when dealing with a generic unmarshaled claims (e.g. form a map[IntOrString]any). Signed-off-by: setrofim <setrofim@gmail.com>

ci: update linters flow to align with local

f215731

Run lint via "make lint" which installs a known version locally, and removes the need to install a pre-built version via GitHub actions. Signed-off-by: setrofim <setrofim@gmail.com>

ci: update Go to 1.26

9ac86e7

Update the Go version used in flows to 1.26 to align with the version declared in go.mod. Signed-off-by: setrofim <setrofim@gmail.com>

setrofim force-pushed the setrofim/misc branch from b9c3768 to 08a3dda Compare October 9, 2026 12:12

setrofim force-pushed the setrofim/misc branch from 08a3dda to c4e4c14 Compare October 9, 2026 12:23

setrofim requested a review from thomas-fossati October 9, 2026 12:25

thomas-fossati approved these changes Oct 9, 2026

View reviewed changes

setrofim merged commit 752feb0 into main Oct 9, 2026
6 checks passed

setrofim deleted the setrofim/misc branch October 9, 2026 14:45

Conversation

setrofim commented Oct 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

yogeshbdeshpande left a comment

Choose a reason for hiding this comment

Uh oh!

yogeshbdeshpande left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

thomas-fossati Oct 9, 2026

Choose a reason for hiding this comment

Uh oh!

setrofim Oct 9, 2026

Choose a reason for hiding this comment

Uh oh!

thomas-fossati Oct 9, 2026

Choose a reason for hiding this comment

Uh oh!

setrofim Oct 9, 2026

Choose a reason for hiding this comment

Uh oh!

thomas-fossati Oct 9, 2026

Choose a reason for hiding this comment

Uh oh!

setrofim Oct 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

thomas-fossati Oct 9, 2026

Choose a reason for hiding this comment

Uh oh!

setrofim Oct 9, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

thomas-fossati left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

setrofim commented Oct 9, 2026 •

edited

Loading

setrofim Oct 9, 2026 •

edited

Loading