Repository navigation
fix(rtc): floor pre-epoch timestamps for timezone lookup - #2531
Merged
adriadam10 merged 1 commit intoOct 11, 2026
Merged
Conversation
|
Thank you for your interest in the project! We are sorry, but we cannot accept more PRs while we work through the existing backlog. This PR has been automatically closed and labeled "intake paused". This is not a judgment of the quality of your changes. |
Collaborator
|
Checked on Linux: the merged tree builds, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Floor pre-epoch tick values to whole seconds before the timezone lookup in
localOffsetSeconds. Integer division truncated toward zero, so a valid timestamp shortly before a DST transition at the Unix epoch selected the later (DST) offset instead of the earlier one, producing a one-hour error.Tested
libstarget, with this change merged into upstreammainfc063cff(retaining the fix(rtc): validate ticks before timezone conversion #2286 regression checks).guest_rtcpasses, including synthetic pre-transition, exact-second, after-transition, in-place and local-formatting cases underTZ=STD0DST,J1/0,J2/0.core/libs/prx/libSceRtc/Export.cppreverted tomain,guest_rtcaborts.python3 tools/check_conventions.py --base mainpasses.The synthetic DST-transition regression is POSIX-only (
#ifndef _WIN32); Windows CRT does not support negative epoch dates. This changes host lookup rounding for valid pre-1970 timestamps; it does not add Windows historical-date support.Checklist
main; no other open PR implements the same functions.mdfiles or images added to the repository