fix: initcontainer indentation (#144)

Simple one-character indentation fix for `extraInitContainers` in the
deployment template.

Note, did not bump `Chart.yaml` on purpose.

Author: tuupke

charts/athens-proxy/templates/deployment.yaml

@@ -82,7 +82,7 @@ spec:
           {{- end }}
       {{- end }}
       {{- if .Values.extraInitContainers }}
-        {{- toYaml .Values.extraInitContainers | nindent 6 }}
+        {{- toYaml .Values.extraInitContainers | nindent 8 }}
       {{- end }}
       {{- end }}
       containers:

charts/athens-proxy/tests/extra_init_containers_test.yaml

@@ -0,0 +1,64 @@
+templates:
+- deployment.yaml
+- config-upstream.yaml
+- config-ssh-git-servers.yaml
+- secret-ssh-git-servers.yaml
+
+tests:
+- it: should not render initContainers by default
+  template: deployment.yaml
+  asserts:
+  - hasDocuments:
+      count: 1
+  - notExists:
+      path: spec.template.spec.initContainers
+
+- it: should render extraInitContainers on their own
+  template: deployment.yaml
+  set:
+    extraInitContainers:
+    - name: init
+      image: busybox:1.28
+      command: ['sh', '-c', "echo 'hello world'"]
+  asserts:
+  - hasDocuments:
+      count: 1
+  - equal:
+      path: spec.template.spec.initContainers
+      value:
+      - name: init
+        image: busybox:1.28
+        command: ['sh', '-c', "echo 'hello world'"]
+
+# Regression: extraInitContainers used a different indentation than the
+# copy-key-files init container, producing invalid YAML when both were set.
+- it: should render extraInitContainers after the sshGitServers init container
+  template: deployment.yaml
+  set:
+    sshGitServers:
+    - host: git.example.com
+      path: "/asd"
+      user: git
+      privateKey: |
+        -----BEGIN RSA PRIVATE KEY-----
+        -----END RSA PRIVATE KEY-----
+      port: 22
+    extraInitContainers:
+    - name: init
+      image: busybox:1.28
+      command: ['sh', '-c', "echo 'hello world'"]
+  asserts:
+  - hasDocuments:
+      count: 1
+  - lengthEqual:
+      path: spec.template.spec.initContainers
+      count: 2
+  - equal:
+      path: spec.template.spec.initContainers[0].name
+      value: copy-key-files
+  - equal:
+      path: spec.template.spec.initContainers[1]
+      value:
+        name: init
+        image: busybox:1.28
+        command: ['sh', '-c', "echo 'hello world'"]