feat(web): rename bookmarks to saves (#3798)

Author: abraham

docs/tutorials/01-configure-app.md

@@ -135,7 +135,7 @@ The build fails when:
 
 With `functions` on, every Cloud Function always deploys. When its feature is off, it logs an error that names the `site.json` key and does nothing. `sendGeneralNotification` needs `notifications`, and `scheduleNotifications` needs `notifications` and `mySchedule`. The functions read the flags and `event.timezone` from `site-config.json`, which their build copies from `site.json`, so deploy the functions again after changing these values.
 
-When `feedback` is off, the feedback dialog is still in the build, but nothing opens it. Bookmark buttons show only when `mySchedule` is on.
+When `feedback` is off, the feedback dialog is still in the build, but nothing opens it. Save buttons show only when `mySchedule` is on.
 
 `socialImages` builds a share image for each session and speaker page, which social networks and chat apps show with a link to the page. A session's image has its title, speakers, day, time and track. A speaker's image has their photo, name, company and the event's dates. Both have the logo from `packages/web/public/images/logo.svg`, the venue and the site's address, in the theme's colors and fonts. The build downloads speaker photos for them, and a photo that fails to download shows the speaker's initials, with a warning in the build output. With `socialImages` off, those pages share the first speaker's photo or `image` from `site.json`.
 

docs/tutorials/03-styling.md

@@ -22,7 +22,7 @@ Hoverboard has four built-in themes. Each has light and dark colors.
 
 - `colorScheme` is `system`, `light` or `dark`. With `system`, the site follows the visitor's device setting, and visitors can pick System, Light or Dark under Appearance in the footer. Their browser remembers the choice. `light` and `dark` lock the site to one scheme and hide the footer choice.
 - `density` is `compact`, `default` or `roomy`. It scales the spacing, not the text or button sizes.
-- `decorations` turns the playful details on or off: dot patterns, tilted stickers and photos, confetti when a visitor bookmarks a session, and the home page illustration. With `false`, the layout stays the same, with plain colors and straight labels. Visitors who ask their device for reduced motion never see the motion.
+- `decorations` turns the playful details on or off: dot patterns, tilted stickers and photos, confetti when a visitor saves a session, and the home page illustration. With `false`, the layout stays the same, with plain colors and straight labels. Visitors who ask their device for reduced motion never see the motion.
 
 The themes are in `packages/web/src/themes/`. `./hb init` asks which one to use.
 

docs/tutorials/05-notifications.md

@@ -16,7 +16,7 @@ To get a notification an attendee has to:
 
 1. Be authenticated
 1. Have enabled "My Schedule notifications"
-1. Have bookmarked the session that is about to start
+1. Have saved the session that is about to start
 
 ### General notifications
 

docs/tutorials/06-security.md

@@ -4,7 +4,7 @@ What Hoverboard protects for you, and what you set in your own Firebase project
 
 ## What Hoverboard does
 
-- **Firestore rules.** Visitors can only read your content. You change it in the Firebase console or with `./hb firestore-*`. Signed-in visitors can write only their own bookmarks, notification settings and feedback. The subscribe and partner forms can only add documents, with checked fields and sizes, and nobody can read them from the site. Export them with [`./hb firestore-csv`](01-configure-app.md#subscribers-and-partner-leads).
+- **Firestore rules.** Visitors can only read your content. You change it in the Firebase console or with `./hb firestore-*`. Signed-in visitors can write only their own saved sessions, notification settings and feedback. The subscribe and partner forms can only add documents, with checked fields and sizes, and nobody can read them from the site. Export them with [`./hb firestore-csv`](01-configure-app.md#subscribers-and-partner-leads).
 - **Storage rules.** The site can't read or write your Storage bucket.
 - **Content.** Links in your config and content can only be `https:`, `http:`, `mailto:` or a path on your site. The site drops other links, such as `javascript:` ones, even when they come straight from the Firebase console. Markdown is sanitized before it is shown, and the build sanitizes the hero illustration.
 - **Headers.** `firebase.json` sends `Strict-Transport-Security`, `Referrer-Policy`, `Permissions-Policy` and other headers on every page, and every page has a [Content Security Policy](01-configure-app.md#content-security-policy).

docs/tutorials/firebase-utils.md

@@ -53,9 +53,9 @@ The safe fixes are:
 - Fields Hoverboard stopped reading, such as `extend` and `shortDescription` on sessions and `timezone` on `config/notifications`, are removed.
 - A missing `updatedAt`, such as on push subscriptions from before the rules required it, is set to the time of the fix.
 - A `subscribers` or `potentialPartners` document without a valid email is deleted, since nobody can answer it. These are usually tests and spam.
-- A `null` entry in `featuredSessions`, which older sites wrote for a removed bookmark, is removed. The site removes the entry now.
+- A `null` entry in `featuredSessions`, which older sites wrote for a session that was unsaved, is removed. The site removes the entry now.
 
-Other problems need an edit in the Firebase console. What visitors wrote is never changed: their data only gets the three fixes above, which add a missing time, drop empty bookmarks or delete the whole document. The plan counts those documents by collection, without their IDs, since they can be push tokens or user IDs.
+Other problems need an edit in the Firebase console. What visitors wrote is never changed: their data only gets the three fixes above, which add a missing time, drop empty saved sessions or delete the whole document. The plan counts those documents by collection, without their IDs, since they can be push tokens or user IDs.
 
 Each write only happens if the document hasn't changed since it was read. A document someone edited in the meantime is left alone and named. Run `--fix` again for it.
 

packages/cli/src/lib/fixes.test.ts

@@ -91,15 +91,15 @@ describe('documentFixes', () => {
     ]);
   });
 
-  it('removes null bookmarks, and keeps the others', () => {
-    const bookmarks = { '101': null, '102': true, '103': null };
-    const fixes = documentFixes('featuredSessions/uid', bookmarks, options);
+  it('removes null saved sessions, and keeps the others', () => {
+    const saved = { '101': null, '102': true, '103': null };
+    const fixes = documentFixes('featuredSessions/uid', saved, options);
 
     expect(fixes.map(({ segments, value }) => [segments.join('/'), value])).toEqual([
       ['101', DELETE],
       ['103', DELETE],
     ]);
-    expect(fieldUpdates(bookmarks, fixes)).toEqual({ '101': DELETE, '103': DELETE });
+    expect(fieldUpdates(saved, fixes)).toEqual({ '101': DELETE, '103': DELETE });
   });
 
   it('sets a missing updatedAt to the current time, in visitor data too', () => {

packages/cli/src/lib/fixes.ts

@@ -100,7 +100,7 @@ const emailError = (error: ErrorObject) =>
 
 /**
  * The fix for an error of a document. Visitor data only gets fixes that add a missing time, drop
- * empty bookmarks or delete a sign-up without a valid email, never ones that change what a visitor wrote.
+ * empty saved sessions or delete a sign-up without a valid email, never ones that change what a visitor wrote.
  */
 const fixIn = (
   documentPath: string,
@@ -115,7 +115,7 @@ const fixIn = (
       description: 'deleted, since its email isn\u2019t valid',
     };
   }
-  // Older sites wrote null for a removed bookmark. The site now removes the entry.
+  // Older sites wrote null for an unsaved session. The site now removes the entry.
   if (segments[0] === 'featuredSessions' && error.keyword === 'type' && error.data === null) {
     return {
       segments: pointer(error.instancePath),

packages/storage/firestore.rules

@@ -88,7 +88,7 @@ service cloud.firestore {
       allow list: if request.auth != null && resource.data.userId == request.auth.uid;
     }
 
-    // Bookmarked sessions: a map of session IDs to booleans.
+    // Saved sessions: a map of session IDs to booleans.
     match /featuredSessions/{userId} {
       allow get, delete: if isOwner(userId);
       allow create, update: if isOwner(userId) && request.resource.data.size() <= 500;

packages/storage/schemas/firestore.schema.json

@@ -410,7 +410,7 @@
       }
     },
     "featuredSessions": {
-      "description": "A signed-in visitor's bookmarked sessions, by session ID. Firestore: `featuredSessions/{userId}`.",
+      "description": "A signed-in visitor's saved sessions, by session ID. Firestore: `featuredSessions/{userId}`.",
       "type": "object",
       "maxProperties": 500,
       "additionalProperties": { "type": "boolean" }

packages/translations/source/en.xlf

@@ -269,14 +269,14 @@
 <trans-unit id="markdown.toc.title">
   <source>On this page</source>
 </trans-unit>
-<trans-unit id="pages.session.bookmarked">
-  <source>Bookmarked</source>
+<trans-unit id="pages.session.saved">
+  <source>Saved</source>
 </trans-unit>
-<trans-unit id="pages.session.bookmark">
-  <source>Bookmark</source>
+<trans-unit id="pages.session.save">
+  <source>Save</source>
 </trans-unit>
-<trans-unit id="schedule.session.bookmark">
-  <source>Bookmark <x id="0" equiv-text="${session.title}"/></source>
+<trans-unit id="schedule.session.save">
+  <source>Save <x id="0" equiv-text="${session.title}"/></source>
 </trans-unit>
 <trans-unit id="common.save-sessions-signed-out">
   <source>Sign in to save sessions</source>
@@ -468,7 +468,7 @@
   <source>Dismiss</source>
 </trans-unit>
 <trans-unit id="shell.sync.help">
-  <source>Bookmarks, feedback and reminders you change are saved on this device, and sync when you are online. Signing in, subscribing and turning on notifications need the internet.</source>
+  <source>Saved sessions, feedback and reminders are kept on this device, and sync when you are online. Signing in, subscribing and turning on notifications need the internet.</source>
 </trans-unit>
 <trans-unit id="common.close">
   <source>Close</source>
@@ -641,8 +641,8 @@
 <trans-unit id="pages.offline.visited">
   <source>Pages you have visited before</source>
 </trans-unit>
-<trans-unit id="pages.offline.bookmarks">
-  <source>Your bookmarked sessions, in My Schedule</source>
+<trans-unit id="pages.offline.saved">
+  <source>Your saved sessions, in My Schedule</source>
 </trans-unit>
 <trans-unit id="pages.post.all-posts">
   <source>All posts</source>
@@ -669,7 +669,7 @@
   <source>Show my time zone, <x id="0" equiv-text="${zoneName(visitorZone)}"/></source>
 </trans-unit>
 <trans-unit id="schedule.my-schedule.empty">
-  <source>Bookmark sessions in the schedule to see them here.</source>
+  <source>Save sessions in the schedule to see them here.</source>
 </trans-unit>
 <trans-unit id="schedule.day.no-results">
   <source>No sessions match these filters.</source>