perf(views): cut the per-row work out of the override editors

Author: chen08209

lib/enum/enum.dart

@@ -450,6 +450,9 @@ enum ItemPosition {
     List<T> items,
     Set<T> deletedItems,
   ) {
+    if (deletedItems.isEmpty) {
+      return ItemPosition.get(currentIndex, items.length);
+    }
     final currentItem = items[currentIndex];
     if (deletedItems.contains(currentItem)) {
       return ItemPosition.middle;

lib/features/overwrite/overwrite_editor_page.dart

@@ -68,15 +68,7 @@ class _OverwriteEditorPageState<T> extends ConsumerState<OverwriteEditorPage<T>>
   Set<dynamic> get _selected =>
       widget.selectionEnabled ? ref.watch(itemsProvider(key)) : const {};
 
-  bool get _isEditing => widget.selectionEnabled && _selected.isNotEmpty;
-
-  dynamic _idOf(T item) {
-    return widget.selectionEnabled ? widget.idOf!(item) : null;
-  }
-
-  bool _isSelected(T item) {
-    return widget.selectionEnabled && _selected.contains(_idOf(item));
-  }
+  dynamic _idOf(T item) => widget.idOf?.call(item) ?? item;
 
   void _handleToggleSelected(T item) {
     if (!widget.selectionEnabled) {
@@ -106,28 +98,34 @@ class _OverwriteEditorPageState<T> extends ConsumerState<OverwriteEditorPage<T>>
     }
   }
 
-  Widget _buildItem(BuildContext context, T item, int index, int total) {
-    final isEditing = _isEditing;
+  Widget _buildItem(
+    BuildContext context,
+    T item,
+    int index,
+    int total,
+    Set<dynamic> selected,
+  ) {
+    final id = _idOf(item);
     final child = ItemPositionProvider(
       position: ItemPosition.get(index, total),
       child: widget.itemBuilder(
         context,
         ref,
         item,
         index,
-        isEditing,
-        widget.selectionEnabled && _isSelected(item),
+        widget.selectionEnabled && selected.isNotEmpty,
+        widget.selectionEnabled && selected.contains(id),
         () => _handleToggleSelected(item),
       ),
     );
     if (widget.dragFromRow) {
       return ReorderableDelayedDragStartListener(
-        key: ValueKey(item),
+        key: ValueKey(id),
         index: index,
         child: child,
       );
     }
-    return KeyedSubtree(key: ValueKey(item), child: child);
+    return KeyedSubtree(key: ValueKey(id), child: child);
   }
 
   @override
@@ -176,14 +174,20 @@ class _OverwriteEditorPageState<T> extends ConsumerState<OverwriteEditorPage<T>>
                 ).copyWith(bottom: 24),
                 itemBuilder: (_, index) {
                   final item = items[index];
-                  return _buildItem(context, item, index, items.length);
+                  return _buildItem(
+                    context,
+                    item,
+                    index,
+                    items.length,
+                    selected,
+                  );
                 },
                 itemExtent: widget.itemExtent,
                 itemCount: items.length,
                 proxyDecorator: (child, index, animation) {
                   final item = items[index];
                   return commonProxyDecorator(
-                    _buildItem(context, item, index, items.length),
+                    _buildItem(context, item, index, items.length, selected),
                     index,
                     animation,
                   );

lib/features/overwrite/overwrite_selection_sheet.dart

@@ -20,7 +20,7 @@ class OverwriteSelectionSheet<T> extends ConsumerWidget {
   final String title;
   final List<OverwriteSelectionSection<T>> sections;
   final String Function(T item) labelBuilder;
-  final bool Function(WidgetRef ref, T item) isSelectedOf;
+  final T? Function(WidgetRef ref) selectedOf;
   final ValueChanged<T> onSelected;
   final double? bottomHeightFactor;
   final String? emptyLabel;
@@ -30,21 +30,20 @@ class OverwriteSelectionSheet<T> extends ConsumerWidget {
     required this.title,
     required this.sections,
     required this.labelBuilder,
-    required this.isSelectedOf,
+    required this.selectedOf,
     required this.onSelected,
     this.bottomHeightFactor = 0.70,
     this.emptyLabel,
   });
 
   Widget _buildItem(
     BuildContext context,
-    WidgetRef ref,
     OverwriteSelectionSection<T> section,
     T item,
     int index,
+    bool isSelected,
   ) {
     final position = ItemPosition.get(index, section.items.length);
-    final isSelected = isSelectedOf(ref, item);
     return ItemPositionProvider(
       position: position,
       child: DecorationListItem(
@@ -69,31 +68,46 @@ class OverwriteSelectionSheet<T> extends ConsumerWidget {
   Widget build(BuildContext context, ref) {
     final height = ref.sheetHeight(context, (bottomHeightFactor ?? 1));
     final isEmpty = sections.every((section) => section.items.isEmpty);
+    final selected = selectedOf(ref);
     return AdaptiveSheetScaffold(
       sheetTransparentToolBar: true,
       body: SizedBox(
         height: height,
         child: isEmpty && emptyLabel != null
             ? NullStatus(label: emptyLabel!)
-            : ListView(
-                padding: const EdgeInsets.symmetric(
-                  horizontal: 16,
-                ).copyWith(bottom: 20, top: context.sheetTopPadding),
-                children: [
+            : CustomScrollView(
+                slivers: [
+                  SliverToBoxAdapter(
+                    child: SizedBox(height: context.sheetTopPadding),
+                  ),
                   for (final section in sections) ...[
                     if (section.label != null) ...[
-                      InfoHeader(info: Info(label: section.label!)),
-                      const SizedBox(height: 4),
+                      SliverPadding(
+                        padding: const EdgeInsets.symmetric(horizontal: 16),
+                        sliver: SliverToBoxAdapter(
+                          child: InfoHeader(info: Info(label: section.label!)),
+                        ),
+                      ),
+                      const SliverToBoxAdapter(child: SizedBox(height: 4)),
                     ],
-                    for (var index = 0; index < section.items.length; index++)
-                      _buildItem(
-                        context,
-                        ref,
-                        section,
-                        section.items[index],
-                        index,
+                    SliverPadding(
+                      padding: const EdgeInsets.symmetric(horizontal: 16),
+                      sliver: SliverList.builder(
+                        itemCount: section.items.length,
+                        itemBuilder: (context, index) {
+                          final item = section.items[index];
+                          return _buildItem(
+                            context,
+                            section,
+                            item,
+                            index,
+                            item == selected,
+                          );
+                        },
                       ),
+                    ),
                   ],
+                  const SliverToBoxAdapter(child: SizedBox(height: 20)),
                 ],
               ),
       ),

lib/providers/generated/state.g.dart

@@ -86,21 +86,14 @@ bool customOverwriteProxiesIsValid(
 }
 
 @riverpod
-bool customOverwriteGroupIsValid(
-  Ref ref,
-  int profileId,
-  ProxyGroup proxyGroup,
-) {
-  final proxies = proxyGroup.proxies ?? [];
-  final use = proxyGroup.use ?? [];
-  final valid = ref.watch(
-    customOverwriteDateProvider(profileId).select(
-      (state) =>
-          state.ruleTargets.containsAll(proxies) &&
-          state.proxyProviders.containsAll(use),
-    ),
-  );
-  return valid;
+Set<int> invalidProxyGroupIds(Ref ref, int profileId) {
+  final overwrite = ref.watch(customOverwriteDateProvider(profileId));
+  return {
+    for (final proxyGroup in overwrite.proxyGroups)
+      if (!overwrite.ruleTargets.containsAll(proxyGroup.proxies ?? const []) ||
+          !overwrite.proxyProviders.containsAll(proxyGroup.use ?? const []))
+        proxyGroup.id,
+  };
 }
 
 @Riverpod(name: 'proxyGroupProvider')

lib/providers/state/overwrite.dart

@@ -50,7 +50,7 @@ class CustomContent extends ConsumerWidget {
         final clashConfig = state.value;
         return (
           hasGroups: clashConfig?.proxyGroups.isNotEmpty ?? false,
-          hasRules: clashConfig?.rules.isEmpty ?? false,
+          hasRules: clashConfig?.rules.isNotEmpty ?? false,
         );
       }),
     );